Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test library with PHP 7.4 #141

Merged
merged 4 commits into from
Dec 10, 2019
Merged

Test library with PHP 7.4 #141

merged 4 commits into from
Dec 10, 2019

Conversation

markuspoerschke
Copy link
Owner

No description provided.

@peter279k
Copy link
Contributor

The php-7.4 version is unstable.

If we want to use this preview version, I think we can use the - "7.4snapshot" in .travis.yml.

The useful references are as follows:

@peter279k
Copy link
Contributor

@markuspoerschke, the latest Travis CI build because of the php-cs-fixer.

The php-xs-fixer doesn't recognize the php-7.4-dev version.

@peter279k
Copy link
Contributor

peter279k commented Aug 7, 2019

I think we can add the condition in Travis CI build setting:

If the PHP version is 7.4-dev, stopping the code coverage generating and coding style check.

And the PHPUnit cannot find the code coverage driver in php-7.4-dev during Travis CI build.

@ankurk91
Copy link

ankurk91 commented Dec 9, 2019

Php 7.4 stable is available on travis ci now

@markuspoerschke markuspoerschke merged commit 884c401 into master Dec 10, 2019
@markuspoerschke markuspoerschke deleted the test-php74 branch December 10, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants